This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[seo] change doc to best practices #800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Jan 25, 2017
| @@ -402,3 +402,5 @@ Whether or not the the :ref:`bundles-seo-alternate-locale` should be loaded | |||
| **type**: ``string`` **default**: ``null`` | |||
|
|
|||
| Specify the service id of a custom :doc:`AlternateLocaleProvider <../seo/alternate_locale>`. | |||
|
|
|||
| .. _phpcr: ../phpcrodm-admin | |||
There was a problem hiding this comment.
why did you add this? This should be transformed into a :doc:`../phpcrodm-admin` link
| @@ -150,22 +150,22 @@ Now, register this new class as a service and tag it as | |||
|
|
|||
| # app/config/services.yml | |||
| services: | |||
| app.suggestions.hompage: | |||
| app.suggestions_hompage: | |||
|
|
||
| .. code-block:: xml | ||
|
|
||
| <!-- app/config/config.xml --> | ||
| <container xmlns="http://symfony.com/schema/dic/services"> | ||
| <config xmlns="http://cmf.symfony.com/schema/dic/seo" | ||
| translation-domain="AcmeDemoBundle" | ||
| translation-domain="AppBundle" |
There was a problem hiding this comment.
Actually, I would use the default messages translation domain for AppBundle translations
| @@ -107,7 +107,7 @@ The templates are specified for a specific sitemap (see below) or in the | |||
| sitemap: | |||
| defaults: | |||
| templates: | |||
| html: AppBundle:Sitemap:default.html.twig | |||
| html: ::itemap/default.html.twig | |||
There was a problem hiding this comment.
Should be sitemap/default.html.twig
| @@ -118,7 +118,7 @@ The templates are specified for a specific sitemap (see below) or in the | |||
| <config xmlns="http://example.org/schema/dic/cmf_seo"> | |||
| <sitemap> | |||
| <defaults> | |||
| <template format="html">AppBundle:Sitemap:default.html.twig</template> | |||
| <template format="html">::sitemap/default.html.twig</template> | |||
| 'sitemap' => [ | ||
| 'defaults' => [ | ||
| 'templates' => [ | ||
| 'html' => '::sitemap/default.html.twig', |
| @@ -253,7 +253,7 @@ sitemaps, you need to explicitly specify ``sitemap`` as well: | |||
| categories: | |||
| default_change_frequency: hourly | |||
| templates: | |||
| html: AppBundle:Sitemap:categories.html.twig | |||
| html: ::sitemap/categories.html.twig | |||
|
fixed against 2. 0 branch in #805 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.