This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[seo] change doc to best practices #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Jan 25, 2017
| @@ -359,24 +362,25 @@ For changing the default translation domain (messages), you should use the | |||
|
|
|||
| # app/config/config.yml | |||
| cmf_seo: | |||
| translation_domain: AcmeDemoBundle | |||
| translation_domain: seo | |||
There was a problem hiding this comment.
this is not using default because it is specifically the example about configuring the translation domain. but i made it more realistic example by using "seo" instead of AppBundle which would just be bad practice.
10 tasks
|
You rock @dbu, all very nice PRs! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.