Skip to content

Make sure one can run XML config examples #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nyholm opened this issue Apr 19, 2021 · 9 comments · Fixed by #46
Closed

Make sure one can run XML config examples #17

Nyholm opened this issue Apr 19, 2021 · 9 comments · Fixed by #46

Comments

@Nyholm
Copy link
Member

Nyholm commented Apr 19, 2021

XML is currently disabled. I got errors on every code block when testing. It is probably me missing something, because I don't think every XML code block is wrong.

@Nyholm
Copy link
Member Author

Nyholm commented Apr 21, 2021

I dont know much about XML config.. but I cannot get it to work at all.

symfony-tools/symfony-application#3

@HeahDude
Copy link
Contributor

HeahDude commented Jun 6, 2022

Maybe symfony/symfony#46594 can partially fix this?

@HeahDude
Copy link
Contributor

HeahDude commented Jun 7, 2022

symfony/symfony#46594 has been merged.
Friendly ping @Nyholm :), anything else needed here to fix the XML config?

@Nyholm
Copy link
Member Author

Nyholm commented Jun 8, 2022

Thank you.

What happens if you enable the xml and run the test on all existing docs locally?

@OskarStark
Copy link

OskarStark commented Jun 8, 2022

What about tagging a new major (aka 0.3.0) of the tool and create a PR on symfony/docs with the new release?

@HeahDude
Copy link
Contributor

HeahDude commented Jun 8, 2022

What happens if you enable the xml and run the test on all existing docs locally?

In any case I may try this tonight, thanks.

@HeahDude
Copy link
Contributor

HeahDude commented Jun 9, 2022

It seems that the tools cannot run on 4.4 is that expected?

@HeahDude
Copy link
Contributor

HeahDude commented Jun 9, 2022

I think we need a branch of this tool dedicated for each major version of Symfony.

@HeahDude
Copy link
Contributor

HeahDude commented Jun 9, 2022

So I've tried, see #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants