Skip to content

Speed up things by using nikic/php-parser #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2021
Merged

Speed up things by using nikic/php-parser #40

merged 1 commit into from
May 16, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 23, 2021

On my machine I verified symfony/symfony-docs in 4m8s before. When using this patch time went down to 1m38s.

This is because we dont start a new process for every code block to actually run the PHP code.

@Nyholm Nyholm force-pushed the nikic-php-parser branch from 4d0589e to 1734ee0 Compare April 23, 2021 20:12
@OskarStark OskarStark changed the title Speed up things by using nikic/php-parser Speed up things by using nikic/php-parser Apr 24, 2021
@Nyholm Nyholm merged commit 61e3635 into symfony-tools:main May 16, 2021
@Nyholm Nyholm deleted the nikic-php-parser branch May 16, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nyholm