Skip to content

Use the same Yaml Parser flags as in Symfony #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2023
Merged

Use the same Yaml Parser flags as in Symfony #49

merged 1 commit into from
Aug 20, 2023

Conversation

ppelisset
Copy link
Contributor

Following a correction suggestion in documentation, I realized that the Yaml parser was not configured with the same options as in Symfony's YamlFileLoader. Therefore, this PR adds the Yaml::PARSE_CONSTANT flag to the Parser.

Reference: https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php#L778

@ppelisset ppelisset mentioned this pull request Aug 17, 2023
Merged
@xabbuh xabbuh mentioned this pull request Aug 18, 2023
Merged
@ppelisset ppelisset force-pushed the fix-yaml-parser-flags branch from ed69a7c to 18b784a Compare August 19, 2023 17:37
@OskarStark OskarStark merged commit e714f03 into symfony-tools:main Aug 20, 2023
@ppelisset ppelisset deleted the fix-yaml-parser-flags branch August 20, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppelisset @xabbuh @chalasr @OskarStark