feature #149 Replace {version} in URLs (alamirault)

javiereguiluz · javiereguiluz · commit 544f4bd4cabf · 2023-03-23T09:48:27.000+01:00
This PR was squashed before being merged into the main branch. Discussion ---------- Replace `{version}` in URLs In order to make link on symfony codebase, even if is not a class or a method reference Can be usefull in this case for example symfony/symfony-docs#17902 Commits ------- 3d54708 Replace `{version}` in URLs
diff --git a/src/KernelFactory.php b/src/KernelFactory.php
@@ -44,7 +44,8 @@ public static function createKernel(BuildConfig $buildConfig, ?UrlChecker $urlCh
             new SymfonyHTMLFormat(
                 $configuration->getTemplateRenderer(),
                 $configuration->getFormat(),
-                $urlChecker
+                $urlChecker,
+                $buildConfig->getSymfonyVersion()
             )
         );
 
diff --git a/src/Renderers/SpanNodeRenderer.php b/src/Renderers/SpanNodeRenderer.php
@@ -25,23 +25,27 @@ class SpanNodeRenderer extends AbstractSpanNodeRenderer
     private $decoratedSpanNodeRenderer;
     /** @var UrlChecker|null */
     private $urlChecker;
+    private $symfonyVersion;
 
     public function __construct(
         Environment $environment,
         SpanNode $span,
         BaseSpanNodeRenderer $decoratedSpanNodeRenderer,
-        ?UrlChecker $urlChecker = null
-    ) {
+        ?UrlChecker $urlChecker = null,
+        string $symfonyVersion = null
+    )
+    {
         parent::__construct($environment, $span);
 
         $this->decoratedSpanNodeRenderer = $decoratedSpanNodeRenderer;
         $this->urlChecker = $urlChecker;
+        $this->symfonyVersion = $symfonyVersion;
     }
 
     /** @inheritDoc */
     public function link(?string $url, string $title, array $attributes = []): string
     {
-        $url = (string)$url;
+        $url = (string) $url;
 
         if (
             $this->urlChecker &&
@@ -55,6 +59,10 @@ public function link(?string $url, string $title, array $attributes = []): strin
             $attributes = $this->addAttributesForUnsafeUrl($attributes);
         }
 
+        if (null !== $this->symfonyVersion) {
+            $url = u($url)->replace('{version}', $this->symfonyVersion)->toString();
+        }
+
         return $this->decoratedSpanNodeRenderer->link($url, $title, $attributes);
     }
 
diff --git a/src/SymfonyHTMLFormat.php b/src/SymfonyHTMLFormat.php
@@ -29,12 +29,14 @@ final class SymfonyHTMLFormat implements Format
     private $htmlFormat;
     /** @var UrlChecker|null */
     private $urlChecker;
+    private $symfonyVersion;
 
-    public function __construct(TemplateRenderer $templateRenderer, Format $HTMLFormat, ?UrlChecker $urlChecker = null)
+    public function __construct(TemplateRenderer $templateRenderer, Format $HTMLFormat, ?UrlChecker $urlChecker = null, string $symfonyVersion = null)
     {
         $this->templateRenderer = $templateRenderer;
         $this->htmlFormat = $HTMLFormat;
         $this->urlChecker = $urlChecker;
+        $this->symfonyVersion = $symfonyVersion;
     }
 
     public function getFileExtension(): string
@@ -69,7 +71,8 @@ function (SpanNode $node) {
                     $node->getEnvironment(),
                     $node,
                     new BaseSpanNodeRenderer($node->getEnvironment(), $node, $this->templateRenderer),
-                    $this->urlChecker
+                    $this->urlChecker,
+                    $this->symfonyVersion
                 );
             }
         );
diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php
@@ -137,6 +137,10 @@ public function parserUnitBlockProvider()
             'blockName' => 'nodes/figure',
         ];
 
+        yield 'span-link' => [
+            'blockName' => 'nodes/span-link',
+        ];
+
         yield 'title' => [
             'blockName' => 'nodes/title',
         ];
diff --git a/tests/fixtures/expected/blocks/nodes/span-link.html b/tests/fixtures/expected/blocks/nodes/span-link.html
@@ -0,0 +1,3 @@
+<p><a href="https://github.com/symfony/amazon-sns-notifier/blob/4.0/README.md" class="reference external" rel="external noopener noreferrer" target="_blank">README file with version substitution</a></p>
+
+<p><a href="https://github.com/symfony/amazon-sns-notifier/blob/version/README.md" class="reference external" rel="external noopener noreferrer" target="_blank">README file without version substitution</a></p>
diff --git a/tests/fixtures/source/blocks/nodes/span-link.rst b/tests/fixtures/source/blocks/nodes/span-link.rst
@@ -0,0 +1,3 @@
+`README file with version substitution <https://github.com/symfony/amazon-sns-notifier/blob/{version}/README.md>`_
+
+`README file without version substitution <https://github.com/symfony/amazon-sns-notifier/blob/version/README.md>`_

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ public static function createKernel(BuildConfig $buildConfig, ?UrlChecker $urlCh`
`44`	`44`	`new SymfonyHTMLFormat(`
`45`	`45`	`$configuration->getTemplateRenderer(),`
`46`	`46`	`$configuration->getFormat(),`
`47`		`- $urlChecker`
	`47`	`+ $urlChecker,`
	`48`	`+ $buildConfig->getSymfonyVersion()`
`48`	`49`	`)`
`49`	`50`	`);`
`50`	`51`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<p><a href="https://github.com/symfony/amazon-sns-notifier/blob/4.0/README.md" class="reference external" rel="external noopener noreferrer" target="_blank">README file with version substitution</a></p>`
	`2`	`+`
	`3`	`+<p><a href="https://github.com/symfony/amazon-sns-notifier/blob/version/README.md" class="reference external" rel="external noopener noreferrer" target="_blank">README file without version substitution</a></p>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+`README file with version substitution <https://github.com/symfony/amazon-sns-notifier/blob/{version}/README.md>`_
	`2`	`+`
	`3`	+`README file without version substitution <https://github.com/symfony/amazon-sns-notifier/blob/version/README.md>`_