-
Notifications
You must be signed in to change notification settings - Fork 25
Replace {version}
in URLs
#149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace {version}
in URLs
#149
Conversation
7d332fc
to
e1d1955
Compare
17eaa57
to
b725fba
Compare
Antoine, thanks for updating the implementation of this PR. I've reviewed it and it looks great to me 👍 I only have a question ... I don't remember the details, but in symfony.com we build Symfony Docs and other docs different from Symfony (Cloud docs, bundles docs, etc.). So, what would happen if we use |
Version is set with Maybe I have to rename Or introduce substitution config in BuildConfig, but I think it's overkill for now |
No ... my question was exactly about that ... if |
It's always value of |
And that makes sense, the other docs should use absolute URLS. @alamirault can you please rename the the PR title accordingly? I think it does not match the current PR content anymore |
Title updated |
@weaverryan can you please merge and release this feature? |
b725fba
to
3d54708
Compare
Thanks Antoine for working on this feature, this is much appreciated. |
Tagged and released as |
In order to make link on symfony codebase, even if is not a class or a method reference
Can be usefull in this case for example symfony/symfony-docs#17902