Fix attribute arguments highlighting and better support CPP #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit into symfony-tools:main from wouterj:php-highlighting-fixes

Aug 2, 2024

Contributor

wouterj commented Jul 31, 2024

@javiereguiluz after seeing my changes online, I discovered 2 minor bugs that are fixed with this PR:

Highlight public/protected/private when using constructor property promotion
Fix highlighting attribute arguments (these were now parsed as function definition parameters instead of invocation arguments, e.g. lacking named argument support)


          Fix attribute arguments highlighting and better support CPP

a467bd9

Collaborator

javiereguiluz commented Aug 2, 2024

This is great! Wouter, you keep improving highlighting more and more 🙌 Thanks 🙇

javiereguiluz merged commit 6702f0d into symfony-tools:main

3 checks passed

wouterj deleted the php-highlighting-fixes branch

August 2, 2024 15:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet