Fix version constraint of symfony deps to v4.4 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am curious why the extra section does not have any effect. |
|
This seams to be working... Let's merge =) |
Nyholm
added a commit
that referenced
this pull request
Dec 8, 2021
* 4.4: Fix version constraint of symfony deps to v4.4 (#9) # Conflicts: # composer.json # symfony.lock
Nyholm
added a commit
that referenced
this pull request
Dec 8, 2021
* 5.2: Add 5.2.* for all symfony deps Fix version constraint of symfony deps to v4.4 (#9) # Conflicts: # symfony.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation described in symfony/symfony-docs#16195
Note that some dependencies are still being bumped to
^5.4(for examplesymfony/http-foundation) when executingcomposer update. I think this is fine; it can still be fixed to^4.4when it really is required (beats having a very longcomposer.json).If this PR is OK like this: The same issue is also present in the other symfony-specific branches. Further, Kernel.php on branch
6.0still has to be fixed.