Swallowed IllegalStateException that can be thrown #1510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id.graphics.pdf.PdfRenderer.close() when switching from one PDF document to another one quickly
ramkumarsync
approved these changes
Nov 16, 2023
|
We are closing this PR, as the changes are already made in the Flutter pdf viewer source. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling android.graphics.pdf.PdfRenderer.close() when switching from one PDF document to another one quickly.
This bug is hard to replicate because it apparently involves a race condition when switching the PDF document of a SfPdfViewer very quickly, which means the former PDF document renderer was not closed yet when the new one is opened.
The Android plugin calls
android.graphics.pdf.PdfRenderer.close(), which itself callsthrowIfPageOpened()here, which can throw an IllegalStateException. And since this exception is not caught by the plugin, it could crash the application and I've seen it pop up randomly in my users' logs.Swallowing this exception is similar to swallowing the IOException, which is already done in the same place in the code.