Proposed fix for https://github.com/systemjs/systemjs/issues/919 #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colmbrady
commented
Nov 18, 2015
- Fix code in cjs.js to correctly match last index of comments.
- Add test module that includes the require('') at end of comment string
- Add unit test to prove the module can be loaded OK with the comment present
- Fix code in cjs.js to correctly match last index of comments.
- Add test module that includes the require('') at end of comment string
- Add unit test to prove the module can be loaded OK with the comment present
| @@ -0,0 +1,15 @@ | |||
| "format cjs"; | |||
There was a problem hiding this comment.
This isn't a valid CommonJS file.
Try just writing:
// This comment triggered SystemJS to do a require because of this -> require('')
exports.exportName = 'export';There was a problem hiding this comment.
true, the penny has just dropped that the existing commonjs-requires.js test file gets executed by the loader, so I just moved the test into there as you originally suggested. Thanks.
- Adding unit test to existing commonjs-requires.js file. - Remove redundant file.
|
Excellent, thanks this all seems to work out nicely now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.