Skip to content

build(deps): upgrade to go1.24.2 #7512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

build(deps): upgrade to go1.24.2 #7512

merged 3 commits into from
Apr 23, 2025

Conversation

matt-boris
Copy link
Contributor

@matt-boris matt-boris commented Feb 12, 2025 •
edited
Loading

Upgrades to go1.24.2.

Also, due to this new version, we can now use the omitzero struct tag, so jsonschema2go was updated to use this on non-default fields.

@matt-boris matt-boris force-pushed the matt-boris/go1.24 branch 5 times, most recently from 1aa0632 to 0b0b59d Compare February 14, 2025 23:11
@matt-boris matt-boris force-pushed the matt-boris/go1.24 branch 4 times, most recently from 875b908 to 476a8bc Compare March 4, 2025 21:15
@matt-boris matt-boris changed the title build(deps): upgrade to go1.24.0 build(deps): upgrade to go1.24.1 Mar 4, 2025
@matt-boris matt-boris force-pushed the matt-boris/go1.24 branch 9 times, most recently from d7e09ac to 72336be Compare March 5, 2025 18:06
@matt-boris matt-boris mentioned this pull request Mar 27, 2025
Merged
@matt-boris matt-boris changed the title build(deps): upgrade to go1.24.1 build(deps): upgrade to go1.24.2 Apr 17, 2025
@matt-boris
Copy link
Contributor Author

Not sure why the TestWhoAmIAsCurrentUser test is failing, but I went ahead and built a staging image off of these changes and ran whoami both as task user and current user and got proper output.

https://community-tc.services.mozilla.com/tasks/T1mycd4EQcurFGDjkkwAAg/runs/0 as current user

https://community-tc.services.mozilla.com/tasks/P2BRKXaFSK-PJUomZp6HHQ/runs/0 as task user

I'll look into rewriting the test, as there were some bigger changes to user.Current() on windows in the go1.24 release https://tip.golang.org/doc/go1.24#osuserpkgosuser.

@matt-boris matt-boris force-pushed the matt-boris/go1.24 branch 3 times, most recently from 4a3d947 to 652f7e3 Compare April 22, 2025 14:15
@matt-boris
Copy link
Contributor Author

Test failing due to golang/go#73471.

@matt-boris matt-boris marked this pull request as ready for review April 23, 2025 16:57
@matt-boris matt-boris requested a review from a team as a code owner April 23, 2025 16:57
@matt-boris matt-boris requested review from lotas and petemoore and removed request for a team April 23, 2025 16:57
petemoore
petemoore approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@petemoore petemoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mammoth job! Perfectly separated into individual commits too, in case we need to revert any of them. Love it.

@matt-boris matt-boris merged commit 938377e into main Apr 23, 2025
71 checks passed
@matt-boris matt-boris deleted the matt-boris/go1.24 branch April 23, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemoore petemoore petemoore approved these changes

@lotas lotas Awaiting requested review from lotas lotas is a code owner automatically assigned from taskcluster/core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-boris @petemoore