Skip to content

Infer result type from result_type arg under string name overload #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Infer result type from result_type arg under string name overload #938

wants to merge 1 commit into from

Conversation

dandavison
Copy link
Contributor

image

@dandavison dandavison requested a review from a team as a code owner July 3, 2025 01:30
@dandavison dandavison force-pushed the workflow-infer-type-from-result-type-arg branch from b173c7f to c665665 Compare July 3, 2025 01:32
cretz
cretz approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be done with workflow things like execute_activity, start_activity, execute_child_workflow, and start_child_workflow?

@dandavison dandavison force-pushed the workflow-infer-type-from-result-type-arg branch from c665665 to ba0303a Compare July 4, 2025 00:46
@dandavison dandavison force-pushed the workflow-infer-type-from-result-type-arg branch from ba0303a to 1097275 Compare August 19, 2025 13:26
@dandavison dandavison force-pushed the workflow-infer-type-from-result-type-arg branch from 1097275 to b9ca006 Compare September 4, 2025 02:10
@dandavison dandavison mentioned this pull request Sep 4, 2025
Open
@dandavison
Copy link
Contributor Author

Should this also be done with workflow things like execute_activity, start_activity, execute_child_workflow, and start_child_workflow?

Yes, opened #1077 to investigate.

@dandavison
Copy link
Contributor Author

The reason this PR hasn't been merged is that it seems to cause mypy to demand type annotations on the LHS of assignments. See 6b0fe3eb9b45ee4eeca8cf8a62855f8e2ece10a1q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@tconley1428 tconley1428 tconley1428 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandavison @cretz @tconley1428