feat: Remove empty containers (map/list) from container definition #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
commented
Aug 7, 2025
| @@ -311,13 +307,14 @@ variable "resourceRequirements" { | |||
| variable "restartPolicy" { | |||
| description = "Container restart policy; helps overcome transient failures faster and maintain task availability" | |||
| type = object({ | |||
| enabled = optional(bool) | |||
| enabled = optional(bool, true) | |||
There was a problem hiding this comment.
we need to add this back for this logic to work https://github.com/terraform-aws-modules/terraform-aws-ecs/pull/336/files#diff-2495e85ca74f46479d907910afcb9c141838715fafd982408869e6e7a5e98bbcR71
bryantbiggs
commented
Aug 7, 2025
| name = var.name | ||
| portMappings = var.portMappings != null ? [for p in var.portMappings : { for k, v in p : k => v if v != null }] : null | ||
| privileged = local.is_not_windows ? var.privileged : null | ||
| pseudoTerminal = var.pseudoTerminal | ||
| readonlyRootFilesystem = local.is_not_windows ? var.readonlyRootFilesystem : null | ||
| repositoryCredentials = var.repositoryCredentials | ||
| resourceRequirements = var.resourceRequirements | ||
| restartPolicy = { for k, v in var.restartPolicy : k => v if v != null } | ||
| restartPolicy = local.trimmedRestartPolicy.enabled ? local.trimmedRestartPolicy : null |
There was a problem hiding this comment.
if enabled = false then we don't send any configs for restartPolicy to the Task Definition API call
antonbabenko
pushed a commit
that referenced
this pull request
Aug 7, 2025
## [6.2.0](v6.1.4...v6.2.0) (2025-08-07) ### Features * Remove empty containers (map/list) from container definition ([#336](#336)) ([24746cc](24746cc))
|
This PR is included in version 6.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
relates to hashicorp/terraform-provider-aws#17988
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestDeploying the
completeexample frommasterand then changing to this PR produces the following desired diff