Process \n as line break in --output-template flag #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing `--output-template` as CLI flag, `\n` is not processed as line break rather than literal strings, which caused a misleading error of "value of '--output-template' should contain at least 3 lines". Signed-off-by: Khosrow Moossavi <khos2ow@gmail.com>
Signed-off-by: Khosrow Moossavi <khos2ow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When passing
--output-templateas CLI flag,\nis not processed asline break rather than literal strings, which caused a misleading error
of "value of '--output-template' should contain at least 3 lines".
Fixes #536
I have:
make test.How has this code been tested
Added all the new test cases in
config_test.go.