Skip to content

Fix error due to leading/trailing whitespace on comments #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccampo133
Copy link

@ccampo133 ccampo133 commented Dec 13, 2022

Description of your changes

Trims leading and trailing whitespace from template comment lines during validation to avoid potential errors.

Fixes #652

I have:

How has this code been tested

@ccampo133 ccampo133 force-pushed the fix/comment_whitespace branch from a0bd338 to 9bcc4f0 Compare December 13, 2022 18:44
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 13, 2022
@ccampo133
Copy link
Author

@khos2ow looks like you are the maintainer of this project? I would appreciate it if you could take a look at this - thanks very much!

@RuiSMagalhaes
Copy link

RuiSMagalhaes commented Jul 20, 2023

any news on this? @khos2ow

@ccampo133
Copy link
Author

I am not sure this project is actually maintained @RuiSMagalhaes, which is a bit unfortunate.

@metmajer
Copy link
Member

Hello, @ccampo133 and @RuiSMagalhaes, previous maintainer and co-owner here. Thanks for your contribution! I have reached out to @khos2ow to understand the current maintenance level.

@ccampo133
Copy link
Author

@khos2ow any update?

@pdonorio
Copy link

pdonorio commented Oct 1, 2024

Hi 👋 @khos2ow it seems you are the main contributor in the last 6 months.
Anything against merging this?
Anyway we can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing space on output.template start/end comments results in Error: value of '--output-template' is missing end comment
5 participants