Fixed binary name in description output of bash completion generation cli command #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested your PR and it passed on my laptop. It also passes on the actions too. So I'm wondering if you are using older go version. What's your |
|
I just installed the go env for this PR via the Ubuntu22.04 apt packages: ~$ go version
go version go1.18.1 linux/amd64
~$ apt show golang
Package: golang
Version: 2:1.18~0ubuntu2 |
|
Ah right, you need at least minimum go 1.19 |
|
Also if you search the whole repo for |
|
Sure i can do that, I didn't think to search because is just stumbled across this instance. In that case, I upgrade my local |
Added missing "s" character in description output. Signed-off-by: @lb1a <github@lb1a.de>
Signed-off-by: Khosrow Moossavi <khos2ow@gmail.com>
b64e6f5 to
d5a55ae
Compare
khos2ow
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added missing "s" character in binary name of the "bash completion CLI helptext" output.
I have:
make test.How has this code been tested
Run
make test. Since i'm not go developer i'm not sure why the tests of a "plain" repo clone on the master branch fails, but my branch also fails after the doc changes... ?!