Codecov Report

Merging #520 (2ba02c9) into main (61d17bd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          664       664           
  Branches       251       251           
=========================================
  Hits           664       664           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Out of curiosity, how is the version determined (major/minor/patch)? I'm guessing this should be released in a minor, not a patch, right?

I think it's determined by the scope on the commit message once merged to main (fix, feat, etc).

I wasn't thinking of this as a new feature because I considered lack of proper ESM support to be a bug 😃, but I also don't feel strongly either way.

Out of curiosity, how is the version determined (major/minor/patch)? I'm guessing this should be released in a minor, not a patch, right?

Ultimately it depends on SemVer, though I'll try to help make a decision. Is any of the work in #519 a breaking change, or is it just meant to restore functionality from Jest DOM 15 in a back compatible way?

There should be no breaking changes, and it's not restoring any functionality. It's publishing ESM modules for the first time, in addition to the CJS that was already being published previously.

Neither a breaking change nor restoring functionality. This is also not really functionality at all, it's just different packaging (dual-publishing to esm/cjs instead of just cjs).

Jinx. ;)

In that case I'd consider it SemVer minor, as it introduces a new API entry without affecting back compatibility.

@nickmccurdy Sounds good, changed to feat. Need another maintainer to approve now.

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

Thanks! I guess it would be good to edit the release notes https://github.com/testing-library/jest-dom/releases/tag/v6.1.0 to include my PR that was not correctly titled (sorry, didn't know it needed a semantic title, maybe it would be good to add a check in CI for that).