feat: move the module to be esm #221

yanick · 2023-06-07T02:12:24Z

To do that I've also switched jest for vitest

NOTE I'm soon going to be potentially without Internet connection. I don't want to merge this and just walk away, so I'll need some 👍 and backup peeps on this one.

Might fix #220

BREAKING CHANGE: moves the package from cjs to esm.

To do that I've also switched jest for vitest **NOTE** I'm soon going to be potentially without Internet connection. I don't want to merge this and just walk away, so I'll need some :+1: and backup peeps on this one.

yanick · 2023-06-07T14:11:04Z

@cesarnml can you try this branch for #220 and see if it solves the problem?

yanick · 2023-06-07T14:14:28Z

fwiw, it works for me (once I installed @testing-library/dom)

cesarnml · 2023-06-07T16:40:43Z

@cesarnml can you try this branch for #220 and see if it solves the problem?

I attempted to apply the patched branch "@testing-library/svelte": "github:yanick/svelte-testing-library", and installed @testing-library/dom, but now I see a new error:

 FAIL  src/routes/page.spec.ts [ src/routes/page.spec.ts ]
Error: Failed to resolve entry for package "@testing-library/svelte". The package may have incorrect main/module/exports specified in its package.json.
 ❯ packageEntryFailure node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:23382:11
 ❯ resolvePackageEntry node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:23379:5
 ❯ tryNodeResolve node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:23113:20
 ❯ Context.resolveId node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:22874:28
 ❯ Object.resolveId node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:42847:46
 ❯ TransformContext.resolve node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:42575:23
 ❯ normalizeUrl node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:40500:34
 ❯ async file:/Users/cesar/code/svelte4-testing-example/node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:40651:47
 ❯ TransformContext.transform node_modules/.pnpm/vite@4.3.9_@types+node@20.2.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:40577:13

Full disclosure.

Module resolution errors are not my cup of tea, so it's perfectly possible that I don't know how to apply the fix properly. Open to suggestions here.

Repo with patched branch:
https://github.com/cesarnml/svelte4-testing-example/blob/759b0999bb8f840f97864bf930707eb69e30c442/package.json#L20

Steps I took from minimal example repo to patch repo:
pnpm i -D yanick/svelte-testing-library
pnpm i -D @testing-library/dom
pnpm test:unit

Let me know if I goofed on applying the fix @yanick

cesarnml · 2023-06-07T16:49:22Z

@yanick

Okay. I just realized I need to target without-babel branch above.

The fix works for me too!

Thank you for the quick turn around time. Only other suggestion I have is to perhaps update the peer dependency designation wrt svelte:

 WARN  Issues with peer dependencies found
.
└─┬ @testing-library/svelte 0.0.0-semantically-released
  └── ✕ unmet peer svelte@3.x: found 4.0.0-next.0

working and patched example:
https://github.com/cesarnml/svelte4-testing-example/blob/1f7ab0768510495fcb5c317b5ae769902bf777c4/package.json#L41

Update:
Patch also works on my production svelte-kit app repo I'm working on. 🎉 🙏 . Ship it 😄
https://github.com/cesarnml/waka-shortcut-time-stats

yanick · 2023-06-07T16:56:35Z

just realized I need to target without-babel branch above.

Heh. You fixed it as I was finding the same thing. ^.^

The fix works for me too! Thank you for the quick turn around time. Only other suggestion I have is to perhaps update the peer dependency designation wrt svelte:

Yeah, we should probably do that once svelte 4.0.0 gets out of alpha.

Update: Patch also works on my production svelte-kit app repo I'm working on. tada pray . Ship it smile https://github.com/cesarnml/waka-shortcut-time-stats

Woo! Now, I'm about to be offline for a few days, so I won't do the mistake of merging and going dark. :turn to the whole room: Do we have another maintainer who can check this PR and, if we merge, keep eyes on the status of things for the next few days?

cesarnml · 2023-06-07T16:57:49Z

Update!: Spoke too soon. Found this error on my production branch above.

Error: No "exports" main defined in /Users/cesar/code/waka-shortcut-time-stats/node_modules/.pnpm/@testing-library+svelte@3.2.2_svelte@4.0.0-next.0/node_modules/svelte/package.json
 ❯ Object.<anonymous> node_modules/.pnpm/@testing-library+svelte@3.2.2_svelte@4.0.0-next.0/node_modules/@testing-library/svelte/dist/pure.js:28:15

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: {
  "code": "ERR_PACKAGE_PATH_NOT_EXPORTED",
}

yanick · 2023-06-07T17:08:42Z

Could be from the pure.js in the root directory. I tweaked it, try again?

cesarnml · 2023-06-07T17:21:01Z

Could be from the pure.js in the root directory. I tweaked it, try again?

 Test Files  31 passed (31)
      Tests  60 passed (60)
   Start at  10:20:19
   Duration  12.71s (transform 1.39s, setup 12.87s, collect 11.49s, tests 1.44s, environment 10.89s, prepare 2.36s)

 % Coverage report from c8

Success. No issues now.

yanick · 2023-06-07T17:22:54Z

Success. No issues now.

I AM A GOD! \o/

cesarnml · 2023-06-07T17:24:33Z

Success. No issues now.

I AM A GOD! \o/

🐐 🤣

benmccann · 2023-06-14T18:23:23Z

package.json

    "husky": "^7.0.1",
-    "jest": "^27.0.0",
+    "jest": "^29.5.0",


Do we need jest and Vitest installed? (also jest-environment-jsdom and svelte-jester)

Oops. Leftover. Removing...

benmccann · 2023-06-14T18:24:24Z

.eslintrc.cjs

@@ -3,29 +3,23 @@ module.exports = {
  env: {
    browser: true,
    es6: true,
-    jest: true
+    jest: true,


Do we still need this line if we're using Vitest?

Hmm... Maybe for the globals. Let's see ! :goes to console:

Switched to the vitest env

dummdidumm · 2023-06-14T19:44:56Z

package.json

@@ -29,21 +30,18 @@
    "e2e"
  ],
  "files": [
-    "dist",


Does probably also need src/pure.js and src/index.js now

benmccann · 2023-06-14T21:05:53Z

package.json

+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-simple-import-sort": "^10.0.0",
+    "eslint-plugin-svelte3": "^4.0.0",


this is the older original package. there's now an eslint-plugin-svelte that you might want to migrate to

benmccann · 2023-06-17T14:55:48Z

package.json

+    "src/pure.js",
+    "src/index.js",


I would make this src/ so that things don't unexpectedly break if you add another file

Suggested change

"src/pure.js",

"src/index.js",

"src/",

Point. Done!

benmccann · 2023-06-17T14:56:31Z

package.json

@@ -29,21 +30,20 @@
    "e2e"
  ],
  "files": [
-    "dist",
+    "src/pure.js",
+    "src/index.js",
    "dont-cleanup-after-each.js",
    "pure.js",


I don't think you need this since it's in src now. not sure what dont-cleanup-after-each is and whether you need that one or not

Suggested change

"pure.js",

Removed both. dont-cleanup-after-each seems to be a helper package for setting the env variable that is not used anywhere anyway.

benmccann · 2023-06-17T14:57:49Z

package.json

+    "eslint": "^8.42.0",
+    "eslint-config-standard": "^17.1.0",
+    "eslint-plugin-import": "^2.27.5",
+    "eslint-plugin-node": "^11.1.0",


I think this one is no longer maintained so folks use eslint-plugin-n now

Good to know! Done!

.eslintrc.cjs

package.json

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

benmccann

I would still recommend putting exports in the package.json. lgtm besides that

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

benmccann · 2023-06-21T15:28:56Z

Svelte 4 will be released imminently. It could be good to merge this in order to avoid any bug reports

yanick · 2023-06-21T15:48:38Z

I can merge, but I'm away from any keyboards for the next 2 weeks, which means that if the branch introduce any problem, things will be broken for a while. Is there any other maintainer that can jump in if this happens?

…

On Wed, 21 Jun 2023, at 5:29 PM, Ben McCann wrote: Svelte 4 will be released imminently. It could be good to merge this in order to avoid any bug reports — Reply to this email directly, view it on GitHub <#221 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE34TDKW4JUJNCX7LY5A3XMMHMFANCNFSM6AAAAAAY5F7G2Y>. You are receiving this because you were mentioned.Message ID: ***@***.***>

benmccann · 2023-06-22T13:16:07Z

I don't have any historical familiarity with this library, but can try to take a look if any issues pop up

yanick · 2023-06-22T19:46:55Z

I don't have any historical familiarity with this library, but can try to take a look if any issues pop up

Okie. There goes nothing!

github-actions · 2023-06-24T08:27:26Z

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

yanick changed the title ~~move the module to be esm~~ breaking: move the module to be esm Jun 7, 2023

yanick changed the title ~~breaking: move the module to be esm~~ feat: move the module to be esm Jun 7, 2023

yanick added 6 commits June 7, 2023 10:06

move the module to be esm

3a1da09

To do that I've also switched jest for vitest **NOTE** I'm soon going to be potentially without Internet connection. I don't want to merge this and just walk away, so I'll need some :+1: and backup peeps on this one.

upgrade eslint

a713c4b

the clean script is no longer required

1fd3662

test the last 3 versions of node

f831101

actually using vitest (duh)

fbdf8eb

fix the tests to work with vitest

313c11e

yanick force-pushed the without-babel branch from c15f692 to 313c11e Compare June 7, 2023 14:06

import the pure.js in src, not dist

7af8d36

benmccann reviewed Jun 14, 2023

View reviewed changes

dummdidumm reviewed Jun 14, 2023

View reviewed changes

benmccann reviewed Jun 14, 2023

View reviewed changes

yanick added 4 commits June 17, 2023 08:39

remove jest and its dependencies

95bb927

move eslint from jest to vitest env

b62ec0d

add src/* to the files

c25bba2

upgrade eslint svelte plugin

f2158eb

benmccann reviewed Jun 17, 2023

View reviewed changes

yanick added 4 commits June 19, 2023 08:42

change eslint-plugin-node for eslint-plugin-n

f8a83ab

plain put src/ in the files listing

af9fb98

remove the root pure.js

34e5b69

remove dont-clean-up-after-each.js

ca6c9bb

benmccann reviewed Jun 19, 2023

View reviewed changes

.eslintrc.cjs Outdated Show resolved Hide resolved

benmccann reviewed Jun 19, 2023

View reviewed changes

.eslintrc.cjs Outdated Show resolved Hide resolved

benmccann reviewed Jun 19, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

benmccann reviewed Jun 19, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

benmccann mentioned this pull request Jun 19, 2023

v4: Vitest component tests crash on switch to svelte4 sveltejs/svelte#8698

Closed

yanick and others added 3 commits June 19, 2023 14:20

tidy code

a22cd00

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

change quotes for prettierification

da13fce

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

put dependencies in alphabetical order

6626a62

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

benmccann approved these changes Jun 19, 2023

View reviewed changes

Update package.json

e2c6877

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

benmccann approved these changes Jun 20, 2023

View reviewed changes

yanick merged commit fe21493 into testing-library:main Jun 22, 2023

github-actions bot added the released label Jun 24, 2023

eroncastro mentioned this pull request Jul 20, 2023

Failed to setup jest with Svelte4 and @testing-library/svelte #252

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: move the module to be esm #221

feat: move the module to be esm #221

yanick commented Jun 7, 2023 •

edited

Loading

yanick commented Jun 7, 2023

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023 •

edited

Loading

cesarnml commented Jun 7, 2023 •

edited

Loading

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023 •

edited

Loading

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023 •

edited

Loading

benmccann Jun 14, 2023 •

edited

Loading

yanick Jun 17, 2023

benmccann Jun 14, 2023

yanick Jun 17, 2023

yanick Jun 17, 2023

dummdidumm Jun 14, 2023

yanick Jun 17, 2023

benmccann Jun 14, 2023

yanick Jun 17, 2023

benmccann Jun 17, 2023

yanick Jun 19, 2023

benmccann Jun 17, 2023

yanick Jun 19, 2023

benmccann Jun 17, 2023

yanick Jun 19, 2023

benmccann left a comment

benmccann commented Jun 21, 2023

yanick commented Jun 21, 2023 via email

benmccann commented Jun 22, 2023

yanick commented Jun 22, 2023

github-actions bot commented Jun 24, 2023

feat: move the module to be esm #221

feat: move the module to be esm #221

Conversation

yanick commented Jun 7, 2023 • edited Loading

yanick commented Jun 7, 2023

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023 • edited Loading

cesarnml commented Jun 7, 2023 • edited Loading

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023 • edited Loading

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023

yanick commented Jun 7, 2023

cesarnml commented Jun 7, 2023 • edited Loading

benmccann Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benmccann left a comment

Choose a reason for hiding this comment

benmccann commented Jun 21, 2023

yanick commented Jun 21, 2023 via email

benmccann commented Jun 22, 2023

yanick commented Jun 22, 2023

github-actions bot commented Jun 24, 2023

yanick commented Jun 7, 2023 •

edited

Loading

cesarnml commented Jun 7, 2023 •

edited

Loading

cesarnml commented Jun 7, 2023 •

edited

Loading

cesarnml commented Jun 7, 2023 •

edited

Loading

cesarnml commented Jun 7, 2023 •

edited

Loading

benmccann Jun 14, 2023 •

edited

Loading