-
Notifications
You must be signed in to change notification settings - Fork 724
Highlights necessary step in Svelte setup #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@MatanBobi Thanks for the feedback! I rephrased the message under Does this phrasing work for
|
That's cool but I'm still missing the "If not, you will need to do manual cleanups after each test" because it's important information IMO. Wdyt? |
I thought that sentence was redundant, since the previous sentence implies if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kyle-n!
@all-contributors please add @kyle-n for docs :) |
I've put up a pull request to add @kyle-n! 🎉 |
@testing-library/svelte requires
globals: true
to runcleanup()
after each test, but this is a bit easy to miss in the docs. This PR highlights this required step.