Skip to content

feat: Remove Router/Vuex for Vue 3 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 23, 2021
Merged

feat: Remove Router/Vuex for Vue 3 #206

merged 6 commits into from
Feb 23, 2021

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Feb 10, 2021 •
edited
Loading

Closes #205. Closes #195.

@afontcu afontcu added the vue3 label Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021 •
edited
Loading

Codecov Report

Merging #206 (12eb923) into next (aa00f27) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              next      #206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           84        77    -7     
  Branches        30        27    -3     
=========================================
- Hits            84        77    -7
Impacted Files Coverage Δ
src/render.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa00f27...400d9f4. Read the comment docs.

@afontcu afontcu marked this pull request as ready for review February 11, 2021 11:34
@afontcu afontcu mentioned this pull request Feb 11, 2021
Closed
ITenthusiasm
ITenthusiasm reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@ITenthusiasm ITenthusiasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I've contributed a little, I haven't seen the entire codebase. So some curious questions will pop up here and there. 😅

@afontcu
Copy link
Member Author

afontcu commented Feb 13, 2021

Although I've contributed a little, I haven't seen the entire codebase. So some curious questions will pop up here and there. 😅

Thank you for your thoughts!

@afontcu afontcu added the BREAKING CHANGE This change will require a major version bump label Feb 17, 2021
@codfish
Copy link

codfish commented Feb 17, 2021

hey @afontcu! looking forward to this change! Out of curiosity, when do you see this being released? I'm migrating to VTL now, but wondering if I should continue on my path or wait a little bit for this change to be released. Also, should we expect this to result in v6?

@afontcu
Copy link
Member Author

afontcu commented Feb 17, 2021

hey @afontcu! looking forward to this change! Out of curiosity, when do you see this being released? I'm migrating to VTL now, but wondering if I should continue on my path or wait a little bit for this change to be released. Also, should we expect this to result in v6?

Hi! Yeah, I plan on releasing it next week. And yeah, I'll release it as a minor version of 6.x, the major range version for Vue 3 :)

codfish
codfish reviewed Feb 17, 2021
View reviewed changes
@codfish codfish mentioned this pull request Feb 20, 2021
Merged
@afontcu afontcu merged commit 3c33dc3 into next Feb 23, 2021
@afontcu afontcu deleted the remove-router-vuex branch February 23, 2021 18:40
@github-actions
Copy link

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@codfish codfish codfish approved these changes

@ITenthusiasm ITenthusiasm ITenthusiasm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afontcu @codfish @ITenthusiasm