Revert "Revert "Make serialized error spec compliant"" #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry, what input do you need me for this? it looks like it ready to be merge? |
name, time_throw and data are now under extensions so we need to extract the values from there instead
|
The code seems alright, I just make the change so that the CI pass. See #52 I hope I don't go MIA again, let me know if you guys see any issue. |
|
Can you get the tests to pass? |
|
I fix the failing test in #52 (It a PR for merging to this PR)… I think once its reviewed and merged this should pass. 👍 |
…liant Fixed broken test for spec compliance PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.