Skip to content

Enforce Composer 1.x for now #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2020
Merged

Enforce Composer 1.x for now #223

merged 1 commit into from
Nov 26, 2020

Conversation

mbrodala
Copy link
Contributor

Summary

Enforce Composer 1.x for now, this keeps the current setup running before it is explicitly adjusted
for Composer 2.x.

This PR fixes/implements the following bugs/features

  • Build failures due to automatic upgrade to Composer 2.x

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output.

Closing issues

Fixes #

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@mbrodala
Enforce Composer 1.x for now
cca549c 
This keeps the current setup running before it is explicitly adjusted
for Composer 2.x
@mbrodala mbrodala mentioned this pull request Nov 23, 2020
Closed
@mbrodala
Copy link
Contributor Author

@moufmouf Any idea about the seemingly unrelated build failure?

chmod: cannot access '/var/lib/snmp/mib_indexes': No such file or directory
The command '/bin/sh -c cd /usr/local/lib/thecodingmachine-php/extensions/current/ && ./install_all.sh && ./disable_all.sh' returned a non-zero code: 1

@mbrodala mbrodala mentioned this pull request Nov 26, 2020
Closed
@moufmouf
Copy link
Member

No idea about the mib_indexes issue. I'll take a look at it. This is related to the SNMP extension. I had to do a weird hack to get it compiling and maybe they fixed the issue meanwhile.

I'll merge this as this is correct and deal with the SNMP problem afterwards.

Thanks!

@moufmouf moufmouf merged commit de5ec26 into thecodingmachine:v3 Nov 26, 2020
@mbrodala mbrodala deleted the composer-v1 branch November 26, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrodala @moufmouf