Skip to content

Preparing v4 release #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Dec 7, 2020
Merged

Preparing v4 release #227

merged 30 commits into from
Dec 7, 2020

Conversation

moufmouf
Copy link
Member

@moufmouf moufmouf commented Dec 4, 2020

  • Adding PHP 8
  • migrating to Composer 2
  • deprecating Node8
  • adding Node 14
  • Migrating to Ubuntu 20.04
  • Putting the "proxy" in charge of creating configuration file on PHP instead of Composer
  • Making configuration editable from docker account (to avoid needing to call sudo which can cause issues in K8S)
  • Also tagging patch releases
  • Migrating build to Github Actions

Closes #221
Closes #218
Closes #213

@moufmouf moufmouf mentioned this pull request Dec 4, 2020
8 tasks
@proton-ab
Copy link

I believe this will be blocked by lack of official release for imagick that supports 8.0 (Imagick/imagick#358) unless you're going to build version off master yourself.

@iquito
Copy link
Contributor

iquito commented Dec 5, 2020

Not having an imagick release for PHP8 should not prevent at least a first version of a PHP8 image, imagick just might not work yet, but a new release of the extension will probably follow soon. And there are seemingly working versions of imagick for PHP8 out there: https://old.reddit.com/r/PHP/comments/k65h85/any_bumps_experienced_when_upgrading_to_php_80/gelz2m6/ - not sure if the same goes for ondrejs repository used by this image, would be worth a try at least.

@proton-ab
Copy link

proton-ab commented Dec 5, 2020

Yes the current master of Imagick repository works fine, there's just no tagged stable release right now which means pecl can't be used.

The version in ondrej repository is last tagged stable with is NOT compatible with PHP 8.

@moufmouf moufmouf changed the title [WIP] Preparing v4 release Preparing v4 release Dec 7, 2020
@moufmouf moufmouf changed the base branch from v3 to v4 December 7, 2020 14:39
@moufmouf
Copy link
Member Author

moufmouf commented Dec 7, 2020

For the v4 release, we are going to remove any extension that is not yet compatible with PHP 8 from the PHP 8 version (and we will document that in the README).
When the extensions are available, we will add those back.

@iquito
Copy link
Contributor

iquito commented Dec 7, 2020

Great! As soon as v4 comes out, I will test it with my projects.

@moufmouf moufmouf merged commit 078b818 into v4 Dec 7, 2020
@moufmouf moufmouf deleted the v4-dev branch December 7, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag patch releases in case of newly introduced bugs Composer 2 in images PHP Startup: Unable to load dynamic library 'redis.so'
4 participants