Support of graphqlite 7 and symfony 7 #70
Conversation
| { | ||
| if (! isset($values['for'])) { | ||
| throw new BadMethodCallException('The @Assert annotation must be passed a target. For instance: "@Assert(for="$email", constraint=@Email)"'); | ||
| /** |
There was a problem hiding this comment.
This looks like a breaking change, no ? I mean people upgrading might get errors if they are using Annotations.
There was a problem hiding this comment.
yes that's BC to support symfony 7
|
Hello @fogrye , thanks a mile for your PR. I'm afraid we might have a breaking change while supporting both version 6 and 7 and introducing attributes. If someone using version 6 with Annotations, they will get errors using What do you think ? |
BC: annotation support dropped, use attributes
|
@nguyenk doctrine annotations are deprecated for a long time and were finally removed in symfony v7, technically somebody can have an issue in symfony 6 with attributes but we have to make it that way |
|
@nguyenk , attributes is the way. |
Symfony v6 is in LTS, I would not drop that. |
I mean to drop the support of symfony v6 in bridge v7. But bridge v6 can still be maintained/supported. |
# Conflicts: # composer.json
|
@nguyenk so I prepared PR to be pushed as v7 because of BC. |
|
Hi @nguyenk I'm also participating in removal of annotations support for graphqlite so I think it's completely ok to drop them in this project. Waiting patiently for your approval. |
|
@nguyenk I see you're not so active lately, I can help you with maintenance of this lib so it would not become a blocker for graphqlite-bundle |
|
Hello folks ! Thank you both for you contribution @SCIF and @fogrye. I'm currently off, and was previously very busy. I did see your proposal to contribute more actively. Let's discuss this further next time I become a blocker again :). v7.0 has just been released. @fogrye I guess you would like to continue with this one ? thecodingmachine/graphqlite-bundle#203 Cheers |
As symfony 7 completely drops support of doctrine annotations I think it's a great timing to drop them and fix this project to work with attributes.