Skip to content

Prepare Statement Cache issue #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2020
Merged

Prepare Statement Cache issue #70

merged 2 commits into from
Jul 24, 2020

Conversation

homersimpsons
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jul 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 70.681% when pulling d2415e6 on homersimpsons:fix/prepare-statement-cache into 3de7b7c on thecodingmachine:1.4.

@homersimpsons homersimpsons changed the title Prepare Statement Cache issue: test case Prepare Statement Cache issue Jul 24, 2020
@moufmouf
Copy link
Member

@homersimpsons 🎉
The fix was actually to assume that is a parameter is passed [] (or null), then it should be cached differently than if another value is passed.

@moufmouf moufmouf merged commit 79e9211 into thecodingmachine:1.4 Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@homersimpsons @coveralls @moufmouf