Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wifi driver comboat for Elecrow W5 rp2040 and rp2350 devices #741

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

scottfeldman
Copy link
Contributor

Combo-AT driver uses AT command set to talk to onboard rtl8720d wifi device. The driver supports UDP/TCP/TLS clients in Wifi STA mode. Support for UDP/TCP servers is not supported, currently.

https://aithinker-combo-guide.readthedocs.io/en/latest/docs/instruction/index.html https://aithinker-combo-guide.readthedocs.io/en/latest/docs/command-set/index.html https://aithinker-combo-guide.readthedocs.io/en/latest/docs/command-examples/index.html

@scottfeldman
Copy link
Contributor Author

I don't understand this build failure.

@deadprogram
Copy link
Member

@scottfeldman the error message is not very clear here
https://github.com/tinygo-org/drivers/actions/runs/13386633341/job/37384751972?pr=741#step:8:596

but the failure is because you are missing the correct build tags for the new board here
https://github.com/tinygo-org/drivers/blob/dev/examples/net/tlsclient/main.go#L8

you will also need it here
https://github.com/tinygo-org/drivers/blob/dev/examples/net/ntpclient/main.go#L6
even though you did not hit that error yet on the CI due to the previous error.

@deadprogram
Copy link
Member

@scottfeldman I think we would be better off creating a specific build tag for comboat and adding it to the boards which have this setup, similar to how the ninafw build tag is used here: https://github.com/tinygo-org/tinygo/blob/dev/targets/pyportal.json#L3

That way new boards which have that tag will "just build". What do you think?

@scottfeldman
Copy link
Contributor Author

@deadprogram sounds good. I'll update PR once I get a work dev env.

@deadprogram
Copy link
Member

Thanks for making the requested changes here @scottfeldman now squash/merging.

@deadprogram deadprogram merged commit 06dd60f into tinygo-org:dev Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants