Change ADC_Commont's group name from ADC to ADC_Common #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to stm32-rs/stm32-rs
that referenced
this pull request
Jul 3, 2022
719: Change the groupName of ADC_Common from ADC to ADC_Common r=adamgreig a=cpunion In the https://github.com/tinygo-org/stm32-svd project, it depends this project and generates types by the peripheral's groupName. Because the ADC_Common's groupName is ADC, it can't generate the types ADC and ADC_Common correctly. I want to change the ADC_Common's groupName to ADC to make it work fine. See tinygo-org/tinygo#2717 , tinygo-org/stm32-svd#7 , but those are not good way. I checked the generated rust code, it's not changed after apply this change and run make, seems it doesn't depend groupName. So can you accept this PR? Co-authored-by: Li Jie <cpunion@gmail.com>
bors bot
added a commit
to stm32-rs/stm32-rs
that referenced
this pull request
Jul 3, 2022
719: Change the groupName of ADC_Common from ADC to ADC_Common r=adamgreig a=cpunion In the https://github.com/tinygo-org/stm32-svd project, it depends this project and generates types by the peripheral's groupName. Because the ADC_Common's groupName is ADC, it can't generate the types ADC and ADC_Common correctly. I want to change the ADC_Common's groupName to ADC to make it work fine. See tinygo-org/tinygo#2717 , tinygo-org/stm32-svd#7 , but those are not good way. I checked the generated rust code, it's not changed after apply this change and run make, seems it doesn't depend groupName. So can you accept this PR? Co-authored-by: Li Jie <cpunion@gmail.com> Co-authored-by: Adam Greig <adam@adamgreig.com>
|
Don't need because changed in stm32-rs/stm32-rs#719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tinygo-org/tinygo#2717
I want to fix those things in generated files of tinygo:
ADC_Commonmust has a different type toADC1/ADC2/etc, by change to a differentgroupName.ADC_Typemust have a correct structureADC_Common's name in some files