reflect, runtime, internal/reflectlite: add iter support #4806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a dependency on the reflect package. I've tried to deduplicate as much as reasonably possible, while keeping the code clean. Especially some tricky methods for the reflect.Type type have a shared implementation (using //go:linkname). In other cases, I've simply used the same type using a type alias, in the other direction (the reflect package now imports the internal/reflectlite package instead of the other way around).
This avoids a circular dependency.
deadprogram
reviewed
Mar 15, 2025
| // for i := range 4 { | ||
| // f(i, i+1) | ||
| // } | ||
| // }), func(t *testing.T, s iter.Seq2[Value, Value]) { |
There was a problem hiding this comment.
Are these supposed to be commented?
There was a problem hiding this comment.
TinyGo reflect doesn't support functions so I disabled those tests.
|
This PR will also address #4487 |
|
Implemented in #4787. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Go 1.24
itersupport to packagereflect.Type.CanSeqandType.CanSeq2Value.SeqandValue.Seq2Fixes #4487.