rp2: use the correct channel mask for rp2350 ADC; hold lock during read #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soypat
reviewed
Jun 27, 2025
|
I guess so. And because the ADC is shared between the analog pins, it's reasonable to support separate goroutines using it simultaneously. |
|
Either we test it or we could do a side-by-side comparison of existing pico-sdk code... or a datasheet walkthrough would work |
|
I've noted it is tested but exhibits no change to behaviour so I'm still curious as to what this CL solves. |
|
The patch does 2 things:
|
|
Alright, LGTM in that case! Thank you for the contribution @eliasnaur ! |
deadprogram
pushed a commit
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while investigating https://github.com/orgs/tinygo-org/discussions/4936.
Untested.