Add lua read_line #286
Closed
Add lua read_line #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this code has not passed system testing yet |
|
Would be best if you squash all your commits into one feature commit. This way it is easier to track changes. |
|
Is there any existing system test script or test methodology? How can we assure that this change makes no regressions? |
|
No, there is no test methodology. I expect people to test the features that they push upstream best they can. |
|
Ok, I still need to find some defect causing the last line read with 'read_line' to be missing. Then I can squash my commits into one and will resubmit it then. Wish me luck! |
…bal options; prevented warnings + Add missing timestamp-format epoch; update send_ to use fsync and tcdrain like normal tty_sync does; rework read_line to save partial line at timeout
4419f2f
to
e5f9b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add read_line for lua scripts