Skip to content

Show the dominant language of a tip4commit repo #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show the dominant language of a tip4commit repo #107

wants to merge 2 commits into from

Conversation

joshumax
Copy link

This commit allows users to quickly see what language their favorite tip4commit repo is written in.

@joshumax
Copy link
Author

@AlexandrZ Thoughts?

@sashazykov
Copy link
Member

I would prefer to move it somewhere else and leave repo names only in the first column. Maybe it's better to show a repo language after its name or in a separate column.

Now it's possible to search by a language. Maybe we don't need to show languages in the list, but add a filter in the header with the list of available languages.

@joshumax
Copy link
Author

@AlexandrZ I can certainly try moving the tags around to see what would look best...As for the second choice of adding a filter, that might be a bit tougher...since statically defining a list of languages to filter by would be quite odd. One way to do this might be to query all of the tip4commit repos at once and insert each unique language to a dynamic filter list, but wouldn't that just create a whole bunch of unneeded backend traffic through the github api? Would there be a better way to do this?

@sashazykov
Copy link
Member

It's easy to get the list: Project.uniq.pluck(:language)

@dennisvandehoef
Copy link
Contributor

@joshumax are you continuing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants