Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Conversation

Sande3p
Copy link
Collaborator

@Sande3p Sande3p commented Aug 10, 2021

No description provided.

Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sande3p I have couple of comments there.

try {
return await sequelize.transaction(async () => {
const newEntity = await instance.update({
...instance.dataValues,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sande3p do we need to pass other fields when updating metadata only?

try {
return await sequelize.transaction(async () => {
const newEntity = await instance.update({
...instance.dataValues,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sande3p same as question with SkillMetadata, do we need other fields to be updated when updating metadata only?

@vikasrohit
Copy link

Closing as we already merged #9

@vikasrohit vikasrohit closed this Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants