Skip to content

fix issue3440 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: nav-bugbash-2
Choose a base branch
from
Open

fix issue3440 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/TopNav/SubNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const SubNav = ({
const to = _.isEmpty(level3.link) ? level3.href : level3.link
return (
<Link
className={cn(styles.secondaryNavItem, level3.id === activeChildId && styles.secondaryNavItemOpen)}
className={cn(styles.secondaryNavItem, level3.id === activeChildId && styles.secondaryNavItemOpen, level3.title === 'All Challenges' && styles.allChallengeClickable)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LieutenantRoger This not a valid solution, because this is hardcoded if we change the menu to any other sentence this fix will stop working.

key={`level3-${i}`}
to={to}
onClick={createHandleClickItem(level3.id)}
Expand Down
4 changes: 4 additions & 0 deletions src/components/TopNav/SubNav.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@
@include Roboto-Bold;
@include not-clickable;
}
&.allChallengeClickable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just add CSS class to specific menu name not valid.

cursor: pointer;
pointer-events: auto;
}
}
}
}