Skip to content

#101 fix bug when all submenus are in "more" menu #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: nav-bugbash-2
Choose a base branch
from
Open

#101 fix bug when all submenus are in "more" menu #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/components/TopNav/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ const TopNav = ({
var menu1 = findLevel1Menu(level1Id)
if (menu1 && menu1.subMenu) {
let subMenu = menu1.subMenu
// all sub menu are all in 'more'
if (subMenu.length === moreMenu.length) {
setChosenArrowPos('more')
return
}
let pos = _.findIndex(subMenu, (level2) => {
return level2.id === menuId
})
Expand Down Expand Up @@ -173,6 +178,21 @@ const TopNav = ({
setChosenArrowX(getMenuCenter(menuId))
}, [setChosenArrowX, getMenuCenter])

useEffect(() => {
// after page first view, when all submenus show in 'more' menu, set chosenArrow below 'more' menu
const { m1 } = getMenuIdsFromPath(menuWithId, path)
var menu1 = findLevel1Menu(m1)
if (menu1 && menu1.subMenu) {
let subMenu = menu1.subMenu
// all sub menu are all in 'more'
if (subMenu.length === moreMenu.length) {
setTimeout(() => {
setChosenArrowPos('more')
})
}
}
}, [(moreMenu || []).length])

const setIconSelectPos = menuId => {
// wait for menuId element to get positioned in its place
setTimeout(() => {
Expand Down