Skip to content

Hotfix 03 March2021 : shapeup pure v5 task #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Hotfix 03 March2021 : shapeup pure v5 task #227

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fc65df
logic change for phaseId
Mar 2, 2021
b1e2faf
typo
Mar 2, 2021
b34e69c
typo
Mar 2, 2021
a225915
correcting phaseid mapping
Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/common/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,11 +376,11 @@ function * getSubmissionPhaseId (challengeId) {
const submissionPh = _.filter(phases, { name: 'Submission', isOpen: true })
const finalFixPh = _.filter(phases, { name: 'Final Fix', isOpen: true })
if (checkPoint.length !== 0) {
phaseId = checkPoint[0].id
phaseId = checkPoint[0].phaseId
} else if (submissionPh.length !== 0) {
phaseId = submissionPh[0].id
phaseId = submissionPh[0].phaseId
} else if (finalFixPh.length !== 0) {
phaseId = finalFixPh[0].id
phaseId = finalFixPh[0].phaseId
}
}
return phaseId
Expand Down Expand Up @@ -459,7 +459,7 @@ function * checkCreateAccess (authUser, subEntity) {
throw new errors.HttpStatusError(403, 'You are not allowed to submit when submission phase is not open')
}

const currPhase = _.filter(phases, { id: submissionPhaseId })
const currPhase = _.filter(phases, { phaseId: submissionPhaseId })

if (currPhase[0].name === 'Final Fix') {
if (!authUser.handle.equals(winner[0].handle)) {
Expand Down