Skip to content

Issue reviewer role only #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Issue reviewer role only #277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
741361a
resource role check
LieutenantRoger Mar 21, 2022
15973ae
adjust naming
LieutenantRoger Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/common/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,18 @@ function * checkCreateAccess (authUser, subEntity) {
const phases = challengeDetails.body.phases
const winner = challengeDetails.body.winners

// Check if the User is assigned as the reviewer for the contest
const reviewers = _.filter(currUserRoles, { role: 'Reviewer' })
if (reviewers.length !== 0) {
throw new errors.HttpStatusError(400, `You cannot create a submission for a challenge while you are a reviewer`)
}

// Check if the User is assigned as the iterative reviewer for the contest
const iterativeReviewers = _.filter(currUserRoles, { role: 'Iterative Reviewer' })
if (iterativeReviewers.length !== 0) {
throw new errors.HttpStatusError(400, `You cannot create a submission for a challenge while you are an iterative reviewer`)
}

// Check if the User is registered for the contest
const submitters = _.filter(currUserRoles, { role: 'Submitter' })
if (submitters.length === 0) {
Expand Down