Skip to content

Little extra debugging for prod issues #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

Little extra debugging for prod issues #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/common/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ async function getReviewTypes () {
*/
async function getReviewTypeId (scorecardName) {
const reviewTypes = await getReviewTypes()
logger.info(`Review types: ${JSON.stringify(reviewTypes, null, 5)}`)
logger.info(`Looking for: ${scorecardName}`)
for (const reviewType of reviewTypes) {
if (reviewType.name === scorecardName) {
return reviewType.id
Expand Down
8 changes: 5 additions & 3 deletions src/common/informixHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,14 @@ async function loadOnlineReviewDetails (authUser, submission) {

// Add the reviews created to DynamoDB
for (const review of reviewsCreated) {
console.log(JSON.stringify(review, null, 4))
await ReviewService.createReview(authUser, review)
if (review && review.typeId) {
logger.info(JSON.stringify(review, null, 4))
await ReviewService.createReview(authUser, review)
}
}

// Adds the review summation to DynamoDB
console.log(JSON.stringify(reviewSummation, null, 4))
logger.info(JSON.stringify(reviewSummation, null, 4))
if (reviewSummation) {
await ReviewSummationService.createReviewSummation(authUser, reviewSummation)
}
Expand Down