Skip to content

HOTFIX - Add flag to load legacy data, with the default being not to #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

HOTFIX - Add flag to load legacy data, with the default being not to #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/services/SubmissionService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ async function listSubmissions (authUser, query) {
// services. We can't do that here because it would introduce a circular dependency because the
// review service calls back to the submission service (this file)
// The check for submission.legacyId is for Phoenix submissions - we won't necessarily have the ID for those.
if (!hasReviewInES && submission.id && submission.legacySubmissionId) {
if (!hasReviewInES && submission.id && submission.legacySubmissionId && query.loadLegacy) {
await informixHelper.loadOnlineReviewDetails(authUser, submission)
}

Expand Down Expand Up @@ -298,6 +298,7 @@ const listSubmissionsQuerySchema = {
challengeId: joi.alternatives().try(joi.id(), joi.string().uuid()),
legacySubmissionId: joi.alternatives().try(joi.id(), joi.string().uuid()),
legacyUploadId: joi.alternatives().try(joi.id(), joi.string().uuid()),
loadLegacy: joi.boolean(),
submissionPhaseId: joi.id(),
page: joi.id(),
perPage: joi.pageSize(),
Expand Down