Skip to content

remove get member profile for registrants tab #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2019
Merged

remove get member profile for registrants tab #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 57 additions & 57 deletions dist/dev/index.js
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 0 additions & 14 deletions docs/services.members.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ members via API V3.
* [new MembersService(tokenV3)](#new_module_services.members..MembersService_new)
* [.getMemberFinances(handle)](#module_services.members..MembersService+getMemberFinances) ⇒ <code>Promise</code>
* [.getMemberInfo(handle)](#module_services.members..MembersService+getMemberInfo) ⇒ <code>Promise</code>
* [.getListMemberInfo(members)](#module_services.members..MembersService+getListMemberInfo) ⇒ <code>Promise</code>
* [.getExternalAccounts(handle)](#module_services.members..MembersService+getExternalAccounts) ⇒ <code>Promise</code>
* [.getExternalLinks(handle)](#module_services.members..MembersService+getExternalLinks) ⇒ <code>Promise</code>
* [.getSkills(handle)](#module_services.members..MembersService+getSkills) ⇒ <code>Promise</code>
Expand Down Expand Up @@ -54,7 +53,6 @@ Service class.
* [new MembersService(tokenV3)](#new_module_services.members..MembersService_new)
* [.getMemberFinances(handle)](#module_services.members..MembersService+getMemberFinances) ⇒ <code>Promise</code>
* [.getMemberInfo(handle)](#module_services.members..MembersService+getMemberInfo) ⇒ <code>Promise</code>
* [.getListMemberInfo(members)](#module_services.members..MembersService+getListMemberInfo) ⇒ <code>Promise</code>
* [.getExternalAccounts(handle)](#module_services.members..MembersService+getExternalAccounts) ⇒ <code>Promise</code>
* [.getExternalLinks(handle)](#module_services.members..MembersService+getExternalLinks) ⇒ <code>Promise</code>
* [.getSkills(handle)](#module_services.members..MembersService+getSkills) ⇒ <code>Promise</code>
Expand Down Expand Up @@ -106,18 +104,6 @@ This method does not require any authorization.
| --- | --- | --- |
| handle | <code>String</code> | Member handle. |

#### membersService.getListMemberInfo(members) ⇒ <code>Promise</code>
Gets public information on a list member.

This method does not require any authorization.

**Kind**: instance method of [<code>MembersService</code>](#module_services.members..MembersService)
**Returns**: <code>Promise</code> - Resolves to the array.

| Param | Type | Description |
| --- | --- | --- |
| members | <code>Array</code> | Array of member info. |

<a name="module_services.members..MembersService+getExternalAccounts"></a>

#### membersService.getExternalAccounts(handle) ⇒ <code>Promise</code>
Expand Down
11 changes: 0 additions & 11 deletions src/services/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,6 @@ export function normalizeChallengeDetails(challenge, filtered, user, username) {
registrants: challenge.registrants || [],
};


_.forEach(finalChallenge.registrants, (registrant) => {
if (registrant.memberInfo) {
const { homeCountryCode } = registrant.memberInfo;
// eslint-disable-next-line no-param-reassign
registrant.countryCode = homeCountryCode || registrant.memberInfo.competitionCountryCode;
}
});

// Winners have different field names, needs to be normalized to match `filtered` and `challenge`
finalChallenge.winners = _.map(
challenge.winners,
Expand Down Expand Up @@ -384,8 +375,6 @@ class ChallengesService {
const challengeUser = username && await this.getUserChallenges(username, { id: challengeId })
.then(res => res.challenges[0]).catch(() => null);

await this.private.memberService.getListMemberInfo(challenge.registrants || [], false);

const finalChallenge = normalizeChallengeDetails(
challenge,
challengeFiltered,
Expand Down
19 changes: 0 additions & 19 deletions src/services/members.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,25 +48,6 @@ class MembersService {
return getApiResponsePayload(res);
}

/**
* Gets public information on a list member.
*
* This method does not require any authorization.
*
* @param {Array} members List member info.
* @param {Boolean} shouldThrowError should throw error if request fail
* @return {Promise} Resolves to the data object.
*/
async getListMemberInfo(members, shouldThrowError = true) {
const getHandle = async (member) => {
const result = await this.private.api.get(`/members/${member.handle}`);
// eslint-disable-next-line no-param-reassign
member.memberInfo = await getApiResponsePayload(result, shouldThrowError);
};
const apis = members.map(member => getHandle(member));
await Promise.all(apis);
}

/**
* Gets member external account info.
* @param {String} handle
Expand Down