Skip to content

fix: provisional score #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

fix: provisional score #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7204b
fix: provisional score
hentrymartin Jul 16, 2025
6fa669d
fix: lint
hentrymartin Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/production.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"AV_SCAN_SCORER_REVIEW_TYPE_ID": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
"AV_SCAN_TYPE_IDS": ["1297f2db-687d-4ac8-bf9c-78b6df1b1281", "2929bc33-8f58-4011-8e49-9e3a10499e97", "55bbb17d-aac2-45a6-89c3-a8d102863d05"],
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "df51ca7d-fb0a-4147-9569-992fcf5aae48"
}
2 changes: 1 addition & 1 deletion dist/dev/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/prod/index.js
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions src/utils/submission.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* eslint-disable no-param-reassign */
import _ from 'lodash';

const { AV_SCAN_SCORER_REVIEW_TYPE_ID, PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID } = CONFIG;
const { AV_SCAN_TYPE_IDS, PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID } = CONFIG;

function removeDecimal(num) {
const re = new RegExp('^-?\\d+');
Expand Down Expand Up @@ -121,7 +121,10 @@ export function processMMSubmissions(submissions) {
if (!data[memberId]) {
data[memberId] = [];
}
const validReviews = _.reject(submission.review, ['typeId', AV_SCAN_SCORER_REVIEW_TYPE_ID]);
const validReviews = _.reject(
submission.review,
review => AV_SCAN_TYPE_IDS.includes(review.typeId),
);
validReviews.sort((a, b) => {
const dateA = new Date(a.created);
const dateB = new Date(b.created);
Expand Down