Skip to content

Fix for Community App Issue #2901 [MSFT-248] Unlabelled button #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix for Community App Issue #2901 [MSFT-248] Unlabelled button #40

wants to merge 1 commit into from

Conversation

gets0ul
Copy link

@gets0ul gets0ul commented Jul 22, 2019

topcoder-platform/community-app#2901

MSFT 248 - Add aria-label to close modal dialog button.

@sexta13 sexta13 self-assigned this Jul 28, 2019
@sushilshinde
Copy link

@gets0ul @sexta13 wrong target branch

@sushilshinde sushilshinde added the On Hold Blocked by another ticket / issue / etc. label Jul 29, 2019
@sushilshinde
Copy link

Use https://github.com/topcoder-platform/topcoder-react-utils/tree/qa-accessibility

@gets0ul
Copy link
Author

gets0ul commented Jul 29, 2019

@sexta13 @sushilshinde
New PR is here: #44

@gets0ul gets0ul closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sexta13 sexta13

Labels
Accessibility Code Review Passed On Hold Blocked by another ticket / issue / etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gets0ul @sushilshinde @sexta13 @crazyk07