Skip to content

GenericLink add onKeyDown handler. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

GenericLink add onKeyDown handler. #42

wants to merge 2 commits into from

Conversation

afrisalyp
Copy link

This was referenced Jul 25, 2019
Open
Closed
@sexta13
Copy link
Collaborator

sexta13 commented Jul 28, 2019

@afrisalyp missing prop types validation.

@sexta13 sexta13 self-assigned this Jul 28, 2019
@afrisalyp
Copy link
Author

@sexta13 Done.

@sushilshinde
Copy link

@afrisalyp @sexta13 wrong target branch

@sushilshinde sushilshinde added the On Hold Blocked by another ticket / issue / etc. label Jul 29, 2019
@sushilshinde
Copy link

Use https://github.com/topcoder-platform/topcoder-react-utils/tree/qa-accessibility

@afrisalyp afrisalyp mentioned this pull request Jul 29, 2019
Merged
@afrisalyp
Copy link
Author

@sushilshinde Done.

A new PR submitted.
#45

@sushilshinde sushilshinde removed the On Hold Blocked by another ticket / issue / etc. label Jul 30, 2019
@sexta13 sexta13 closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sexta13 sexta13

Labels
Accessibility Code Review Passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrisalyp @sexta13 @sushilshinde @crazyk07