Skip to content

make id unique (https://github.com/topcoder-platform/community-app/issues/3095) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jul 30, 2019
Merged

make id unique (https://github.com/topcoder-platform/community-app/issues/3095) #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default async function Launch({
moduleHot.addStatusHandler((status) => {
if (status !== 'ready') return;
const stamp = shortId();
const links = document.querySelectorAll('link[rel=stylesheet][id="tru-style"]');
const links = document.querySelectorAll('link[rel=stylesheet][id^="tru-style"]');
for (let i = 0; i < links.length; i += 1) {
links[i].href = `${links[i].href.match(/[^?]*/)}?v=${stamp}`;
}
Expand Down
2 changes: 1 addition & 1 deletion src/server/renderer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export default function factory(webpackConfig, options) {
assets = assets.filter(asset => asset.endsWith('.css'));
assets.forEach((asset) => {
styles.push((
`<link data-chunk="${chunk}" id="tru-style" href="${publicPath}${asset}" rel="stylesheet" />`
`<link data-chunk="${chunk}" id="tru-style-${chunk.replace('/', '-')}" href="${publicPath}${asset}" rel="stylesheet" />`
));
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/shared/containers/AppChunk/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export default class SplitRoute extends React.Component {
link = document.createElement('link');
link.setAttribute('data-chunk', chunkName);
link.setAttribute('href', `${PUBLIC_PATH}/${chunkName}-${timestamp}.css`);
link.setAttribute('id', 'tru-style');
link.setAttribute('id', `tru-style-${chunkName.replace('/', '-')}`);
link.setAttribute('rel', 'stylesheet');
const head = document.getElementsByTagName('head')[0];
head.appendChild(link);
Expand Down