-
Notifications
You must be signed in to change notification settings - Fork 23
[$80] When you log in (successfully) the login window remains open (also when you log out) #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like there are also some other side effects of this bug with login which I ran into when participating challenge https://www.topcoder.com/challenge-details/30056080/?type=develop Let's say I login as a pilot and redirect user to the pilot mission list page.
|
You can set poor network conditions in the Chrome dev tools, I think you will 100% get it. |
Also note that there are supposed to be additional menu entries after you log in. I've been refreshing my browser after I enter my credential to get that login window to disappear. This allows the new menu items to show up. However, I just realized that I can also click the 'X' on the login window. However when I do that, the box closes - but the new menu items don't appear. The intention here is to fix it so that it works correctly (including the menu) when the user logs in / logs out. |
…w remains open (also when you log out) Fixes topcoderinc#19
Ready. You may consider to up the payment a bit, as it was not just that smb forgot to close the modal after login, but the login logic as whole had flaws and was not implemented in the correct React/Redux way. So I had to dig into it a bit, to find out what is going on, and how it should be re-written. |
Issue #19 - When you log in (successfully) the login window remains o…
…pen (also when you log out) Fixes #19
Form login works correctly, but still need to refresh the page on social login. AuthService#parseHash doesn't even try do anything but set the key on login. Can you clear that up too ? |
Done #27 |
It will be handled today |
Payment Scheduled: https://apps.topcoder.com/bugs/browse/DRONESERIES-7 |
Sorry My fault you should see it soon |
Uh oh!
There was an error while loading. Please reload this page.
When you logout also there is no refresh of the screen (showing that you're logged out).

The text was updated successfully, but these errors were encountered: