Skip to content

[$80] When you log in (successfully) the login window remains open (also when you log out) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtwomey opened this issue Jan 3, 2017 · 11 comments
Assignees

Comments

@mtwomey
Copy link
Contributor

mtwomey commented Jan 3, 2017

When you logout also there is no refresh of the screen (showing that you're logged out).
screen shot 2017-01-03 at 5 14 45 pm

@mtwomey mtwomey changed the title [$50] When you log in (successfully) the login window remains open [$50] When you log in (successfully) the login window remains open (also when you log out) Jan 3, 2017
@maxceem
Copy link

maxceem commented Jan 4, 2017

It looks like there are also some other side effects of this bug with login which I ran into when participating challenge https://www.topcoder.com/challenge-details/30056080/?type=develop

Let's say I login as a pilot and redirect user to the pilot mission list page.
Even though login window could close successfully, but when performing request to the server if I need information about logged in user it could be not there yet:

  • accessToken could be still undefined in APIService
  • state.global.user.id could be still undefined too

@birdofpreyru birdofpreyru self-assigned this Jan 4, 2017
@maxceem
Copy link

maxceem commented Jan 4, 2017

You can set poor network conditions in the Chrome dev tools, I think you will 100% get it.
http://joxi.ru/812Myw4TEDkq2J

@mtwomey
Copy link
Contributor Author

mtwomey commented Jan 4, 2017

Also note that there are supposed to be additional menu entries after you log in. I've been refreshing my browser after I enter my credential to get that login window to disappear. This allows the new menu items to show up. However, I just realized that I can also click the 'X' on the login window. However when I do that, the box closes - but the new menu items don't appear. The intention here is to fix it so that it works correctly (including the menu) when the user logs in / logs out.

screen shot 2017-01-04 at 10 20 33 am

birdofpreyru added a commit to birdofpreyru/dsp-frontend that referenced this issue Jan 4, 2017
@birdofpreyru
Copy link
Collaborator

Ready. You may consider to up the payment a bit, as it was not just that smb forgot to close the modal after login, but the login logic as whole had flaws and was not implemented in the correct React/Redux way. So I had to dig into it a bit, to find out what is going on, and how it should be re-written.

gondzo added a commit that referenced this issue Jan 5, 2017
Issue #19 - When you log in (successfully) the login window remains o…
gondzo pushed a commit that referenced this issue Jan 5, 2017
@gondzo
Copy link
Contributor

gondzo commented Jan 5, 2017

Form login works correctly, but still need to refresh the page on social login. AuthService#parseHash doesn't even try do anything but set the key on login. Can you clear that up too ?
Payment increased to 80$

@gondzo gondzo changed the title [$50] When you log in (successfully) the login window remains open (also when you log out) [$80] When you log in (successfully) the login window remains open (also when you log out) Jan 5, 2017
@birdofpreyru
Copy link
Collaborator

Done #27

@birdofpreyru
Copy link
Collaborator

@mtwomey @gondzo Any plans to pay for this and #18 any soon? Both payments are pending for one month.

Also, I'm wondering what's up with this project? It was very active around the New Year, many challenges and staff going on, but I have not seen that much activity recently.

@gondzo
Copy link
Contributor

gondzo commented Feb 1, 2017

It will be handled today

@kbowerma
Copy link
Contributor

kbowerma commented Feb 1, 2017

Payment Scheduled: https://apps.topcoder.com/bugs/browse/DRONESERIES-7

@kbowerma kbowerma closed this as completed Feb 1, 2017
@birdofpreyru
Copy link
Collaborator

@kbowerma Two days later, the payment is still not in my PACTS, can you verify everything is correct (I don't have permissions to access the URL in your last comment myself)? Same with the other one (#18)

@kbowerma
Copy link
Contributor

kbowerma commented Feb 3, 2017

Sorry My fault you should see it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants