Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rng.js: IE 7-8, Object doesn't support property or method 'addEventListener' #10

Closed
zenatti opened this issue Oct 7, 2013 · 5 comments
Closed

rng.js: IE 7-8, Object doesn't support property or method 'addEventListener' #10

zenatti opened this issue Oct 7, 2013 · 5 comments

Comments

@zenatti
Copy link

zenatti commented Oct 7, 2013

Internet Explorer 7 and 8 doesn't support addEventListener and removeEventListener used in nrg.js at lines 24 and 32.
@zoloft
Copy link
Collaborator

zoloft commented Oct 8, 2013

Thank you for the report, the fix should be easy, just replacing addEventListener with attachEvent and removeEventListener with detachEvent should do the trick. I'll do it as soon as possible, right now i can't work on it

@zoloft zoloft mentioned this issue Oct 8, 2013
Merged
@travist
Copy link
Owner

travist commented Oct 8, 2013

@zenatti , would you please pull in @zoloft pull request and test it on your end? If it works well, then I will merge it into the codebase as a fix.

Thanks again @zoloft for your work on this library.

@zenatti
Copy link
Author

zenatti commented Oct 9, 2013

Yes, now it works on IE 6, 7 and 8.
Thanks ;)

@zoloft
Copy link
Collaborator

zoloft commented Oct 9, 2013

Thanks to you for your report :)

@travist
Copy link
Owner

travist commented Oct 9, 2013

Closed and fixed. Thank you @zoloft and @zenatti

@travist travist closed this as completed Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@travist @zenatti @zoloft