Fix IE not implementing addEventListener/removeEventListener #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2013 22:23
…eplaced with add/detach Event
|
He said it works. Thanks again @zoloft |
travist
added a commit
that referenced
this pull request
Oct 9, 2013
Fix IE not implementing addEventListener/removeEventListener
|
No problem ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #10. The fix is simple if window.addEventListener exists it will be used otherwise if attachEvent exists it will be used instead. If none of them exists (browsers that should die) simply ignore it and move on, the entropy will be generated later by Math.random.
Sadly i cannot test this, so if someone with IE (most notably IE 7/8) can test this it would be great
Antonio