Skip to content

1 is not prime #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

1 is not prime #11

wants to merge 2 commits into from

Conversation

ricsam
Copy link

@ricsam ricsam commented May 24, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #11 into master will decrease coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage     100%   99.43%   -0.57%     
==========================================
  Files          76       76              
  Lines        1596     1596              
  Branches      282      282              
==========================================
- Hits         1596     1587       -9     
- Misses          0        6       +6     
- Partials        0        3       +3
Impacted Files Coverage Δ
...rc/algorithms/math/primality-test/trialDivision.js 18.18% <100%> (-81.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bef39...e826736. Read the comment docs.

@trekhleb
Copy link
Owner

@ricsam thank you for pointing that out!
The tests for current pull request have been failed though.
So I've fixed the issue manually.

@trekhleb trekhleb closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants