-
Notifications
You must be signed in to change notification settings - Fork 588
Added Shortcut Panel #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@samejr Please check this PR |
matt-aitken
reviewed
May 23, 2022
1 similar comment
Hey @123OM123 it's looking great 👍. Here are a few tweaks:
|
@samejr I made all the changes you recommended. |
matt-aitken
requested changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I've been slow looking at this, busy with other work at the moment.
I'm happy with this except for the faking click code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This pull request adds a panel that shows you every shortcut that the app uses. It is available after you either:
It can be opened using:
Alt/Option + S
which can be seen in the button on the left-hand side of the footerWhen opened, it shows you a list of the app's shortcuts, all in their own categories, with icons for each of the shortcuts on the left. All shortcuts that use an OS-dependent modifier key (eg.
Cmd (Mac) / Ctrl (Windows/Linux)
) will only show the shortcut using the key that the user's OS would use.The panel is also dark mode styled and will change when the user toggles dark mode.
The panel can be closed by:
Alt/Option + S
)There is a demo Loom video below where you can see all the functionalities that I described above in practice
https://www.loom.com/share/bd12894537f342a7bac126bf3518bb7e