Skip to content

Commit 7dbdd0b

Browse files
committed
fix (hmr): Change for fixing both HMR issues nativescript-vue#461 and nativescript-vue#470 in NS 5.2 and 5.3
1 parent 621e7e6 commit 7dbdd0b

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

platform/nativescript/runtime/components/frame.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { setFrame, getFrame, deleteFrame } from '../../util/frame'
22
import { isHMRChecking, resetHMRChecking } from '../../util/hmr'
33
import { isAndroid, isIOS } from 'tns-core-modules/platform'
44
import { ios as iosUtils } from 'tns-core-modules/utils/utils'
5+
import { _setAndroidFragmentTransitions } from 'tns-core-modules/ui/frame/fragment.transitions'
56

67
let idCounter = 1
78

platform/nativescript/runtime/components/list-view.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export default {
5151

5252
mounted() {
5353
if (!this.$templates) {
54-
return;
54+
return
5555
}
5656

5757
this.$refs.listView.setAttribute(
@@ -69,9 +69,9 @@ export default {
6969
},
7070
onItemLoading(args) {
7171
if (!this.$templates) {
72-
return;
72+
return
7373
}
74-
74+
7575
const index = args.index
7676
const items = args.object.items
7777

platform/nativescript/runtime/components/page.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { isAndroid } from 'tns-core-modules/platform'
12
import {
23
findParentNavigationEntry,
34
getFrameInstance
@@ -22,7 +23,7 @@ export default {
2223

2324
let frame = null
2425

25-
if (isHMRChecking()) {
26+
if (isHMRChecking() && !isAndroid) {
2627
const navEntry = findParentNavigationEntry(this)
2728
const options = {
2829
frame: navEntry ? navEntry.$options.frame : 'default'

platform/nativescript/runtime/modules/transition.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ export function enter(vnode, toggleDisplay) {
7676

7777
const beforeEnterHook = isAppear ? beforeAppear || beforeEnter : beforeEnter
7878
const enterHook = isAppear
79-
? typeof appear === 'function' ? appear : enter
79+
? typeof appear === 'function'
80+
? appear
81+
: enter
8082
: enter
8183
const afterEnterHook = isAppear ? afterAppear || afterEnter : afterEnter
8284
const enterCancelledHook = isAppear

0 commit comments

Comments
 (0)